Towing vehicles #34690

ghost · 2019-10-12T21:16:44Z

Summary

SUMMARY: Features "Towing vehicles"

Purpose of change

Allows you to tow a vehicle with another one, by attaching a tow-line.

this relies on some of the changes in #34616 , and therefore has those commits too.

Describe the solution

Add an item that is similar to charging cable in how it attaches to a vehicle.
When it attaches it sets references to each vehicle to the other, when the puller moves, the pulled vehicle moves too.

Describe alternatives you've considered

N/A

Testing

Still to do :-
1)saving/loading - DONE
2)currently there are pointers stored on each vehicle, these need to be managed with care to ensure they are removed and not left dangling when certain things happen - such as destruction of a vehicle, destruction of the tow line part etc. - DONE
3)Make the tow-line have more than 3 "charges" so it can be spooled further out. - DONE
4) tweak the code that makes it follow closely, so that it is smarter. - DONE
5) handle vehicle getting unloaded out of reality bubble etc. - DONE
6)add weight to the pulling vehicle to represent the added strain of the pulled vehicles weight. - DONE
7) if pulled vehicle has no wheels, make it skid? make it create shallow pits in the ground? - THIS ALREADY HAPPENS AUTOMATICALLY
8) need to handle obstacles interfering with the pulled vehicle, or when too much distance opens up between the vehicles. or when the pulled vehicle is driven away ( need to make it bidirectional somehow maybe? ) - DONE
9) spawn in various places, make it craftable. - DONE

handle vehicles splitting / loaded onto racks - DONE

current limitations :
The order in which you apply the cable matters, first vehicle selected is the puller, second is the pulled, Ima see if I can work around that.
It really is better if you attach the tow-line to the rear of the puller, and the front of the pulled.
Otherwise weird things may happen.

Additional context

A gif of it -
https://gfycat.com/disguisedweepyladybug

chaisawlajatang · 2019-10-12T21:26:10Z

Oh, wow. WOW

Destragon · 2019-10-12T21:52:24Z

Can you chain them and have another car being pulled by the pulled vehicle or is it limited to just 1?

ghost · 2019-10-12T21:57:49Z

Can you chain them and have another car being pulled by the pulled vehicle or is it limited to just 1?

Currently if a vehicle is either a tower, or a towed, then you cant attach another cable to it, I did this deliberately to keep things simple.

But I guess a towee, could also be a tower, and theoretically yes it could chain. Id be wary of it though, it would multiply the chances for things to go wrong.

Destragon · 2019-10-13T01:04:36Z

Will anything funny happen when #33829 gets merged and you tie a car to a helicopter?

ghost · 2019-10-13T09:30:03Z

Will anything funny happen when #33829 gets merged and you tie a car to a helicopter?

Quite likely very strange things would happen.

ghost · 2019-10-17T16:00:15Z

Rebased to latest changes in #34616

Destragon · 2019-10-18T02:08:27Z

Does the towed vehicle keep its momentum when the tower suddenly hits on the breaks or does it also stop immediately?

ghost · 2019-10-18T12:22:20Z

Does the towed vehicle keep its momentum when the tower suddenly hits on the breaks or does it also stop immediately?

Theres no momentum, the towed vehicle is kinda driving itself, and when the distance gets less than a certain number, then it stops moving. So no hard braking and having thw towed vehicle ram into you, not yet anyway :)

src/iuse.cpp

RustyBrute · 2019-10-22T09:34:49Z

Hell yeah! Good job.

src/game.cpp

src/vehicle.cpp

data/json/vehicleparts/vehicle_parts.json

Night-Pryanik · 2019-10-24T08:15:32Z

Could you please add tow cable to the list of possible alternatives of rope in butchering activity?

ghost · 2019-10-24T10:36:17Z

Could you please add tow cable to the list of possible alternatives of rope in butchering activity?

Done

mlangsdorf

C++ code looks good. Just need to beef up the towing line - this is 50' of 1" stick cable that can tow roughly 100,000 lbs, which is sufficiently close to "unlimited weight".

When you go back and add some weight limits, we can add some lighter tow cable and some tow lines and/or ropes.

data/json/items/vehicle/cables.json

data/json/recipes/recipe_vehicle.json

data/json/items/vehicle/cables.json

paulenka-aleh · 2019-10-30T19:02:51Z

It looks great to finally see the concept in game. It feels a bit wrong though:

Towing support
After the collision rework, it should be possible to have two correctly flagged vehicle parts not collide. And it should also be possible to apply force to the trailer to have it follow the towing vehicle.
Added by mlangsdorf

https://github.com/CleverRaven/Cataclysm-DDA/projects/19

ghost · 2019-10-31T23:06:46Z

It looks great to finally see the concept in game. It feels a bit wrong though:

Towing support
After the collision rework, it should be possible to have two correctly flagged vehicle parts not collide. And it should also be possible to apply force to the trailer to have it follow the towing vehicle.
Added by mlangsdorf

https://github.com/CleverRaven/Cataclysm-DDA/projects/19

This is a different route to the same end-goal, what feels wrong exactly?

stale · 2019-11-30T23:09:01Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

pjf · 2020-03-25T19:42:13Z

Applied this to my local game, and had my deathmobile tow a 4x4.

Worked great on roads, but as soon as I got off-road, my deathmobile continued (slowly), but the vehicle it was towing did not.

The deathmobile isn't built for off-road use, so I suspect the weight of both vehicles combined exceeded its engine capacity. However in that case I'd expect the towing vehicle to stop, not the vehicle being towed.

Otherwise this is great. An excellent change for folks who have multiple vehicles and like to relocate. Thank you!

add UI and sound cues for autopilot, and rework collision detection remove test code simple towin WIP Update src/iuse.cpp Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com> increase cable length, and enable serialization/validation of tow data in-progress - invalidate towing and dump cable part add handling to clear towing data on part/vehicle destruction or too much distnace json lint make recipe use metal cables transfer tow data when vehicle splits DEATH TO AUTO change breaks_into to use new metal recipe from review: add tow cable to butchery hanging options from review : change recipe to be HD cable replace item groups entries for tow_cable with hd_tow_cable json typo clang-tidy satisfaction - redundant bool return and differing paramters add cable to recipe make towing aware of side it is pulled from for reverse pulling

…speed

ghost · 2020-04-03T12:34:15Z

Rebased, cleaned up, tested, working.
Fixed bug that pjf reported .

Im not sure why the tower is allowed to proceed at velocity 1, when the towed vehicle stops at velocity 1.

I managed to repro this with a bus pulling a bus, and they went off-road, this would be a situation where probably it would be impossible to get traction, so ive detected this scenario and added a message similar to when a vehicle is too heavy for its engines.

Pulling a golf cart with a military cargo truck off-road didnt have this problem, it managed to stay above 1mph.

CEG86 · 2020-04-25T07:52:21Z

How do you detach the tow cable? I had to deconstruct the towed vechicle which resulted in the tow cable disappearing.

ZhilkinSerg · 2020-04-25T08:06:58Z

Try examining vehicle tile with tow attachment.

KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions labels Oct 12, 2019

KorGgenT reviewed Oct 20, 2019

View reviewed changes

src/iuse.cpp Outdated Show resolved Hide resolved

ghost changed the title ~~[WIP]Towing vehicles~~ Towing vehicles Oct 23, 2019

KorGgenT reviewed Oct 23, 2019

View reviewed changes

src/game.cpp Show resolved Hide resolved

KorGgenT reviewed Oct 23, 2019

View reviewed changes

src/vehicle.cpp Outdated Show resolved Hide resolved

KorGgenT reviewed Oct 23, 2019

View reviewed changes

src/vehicle.cpp Outdated Show resolved Hide resolved

KorGgenT reviewed Oct 23, 2019

View reviewed changes

src/vehicle.cpp Outdated Show resolved Hide resolved

Night-Pryanik reviewed Oct 24, 2019

View reviewed changes

data/json/vehicleparts/vehicle_parts.json Outdated Show resolved Hide resolved

mlangsdorf self-requested a review October 24, 2019 14:11

mlangsdorf reviewed Oct 24, 2019

View reviewed changes

ZhilkinSerg added the 0.E Feature Freeze label Nov 11, 2019

stale bot added the stale Closed for lack of activity, but still valid. label Nov 30, 2019

anothersimulacrum mentioned this pull request Nov 30, 2019

Prevent stalebot from stale-ing PRs in feature freeze. #35796

Merged

KorGgenT added the (P5 - Long-term) Long-term WIP, may stay on the list for a while. label Nov 30, 2019

stale bot removed the stale Closed for lack of activity, but still valid. label Nov 30, 2019

ghost changed the title ~~[WIP]Towing vehicles~~ Towing vehicles Mar 6, 2020

ZhilkinSerg force-pushed the dev branch 2 times, most recently from aa39539 to 9761f13 Compare March 10, 2020 09:21

ZhilkinSerg force-pushed the dev branch 6 times, most recently from 924f105 to 39e00e3 Compare March 18, 2020 07:00

ZhilkinSerg force-pushed the dev branch 3 times, most recently from ad63e77 to 8e68539 Compare April 1, 2020 12:18

kevingranade force-pushed the dev branch 4 times, most recently from 621a68e to b7106d0 Compare April 2, 2020 07:42

ZhilkinSerg force-pushed the dev branch 3 times, most recently from 0f30a43 to d432807 Compare April 2, 2020 12:55

ZhilkinSerg changed the base branch from dev to master April 2, 2020 14:31

davidpwbrown added 5 commits April 3, 2020 10:20

add handling for sidepulling and reearpulling without vehicle flipping

e29a5af

disallow tow move across z-levels

ddc10ad

pointer ->

328cda0

stop tower if towed vehicle weight on poor ground results in minimal …

f90ca49

…speed

ZhilkinSerg merged commit c410ebb into CleverRaven:master Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Towing vehicles #34690

Towing vehicles #34690

ghost commented Oct 12, 2019 •

edited by ghost

Loading

chaisawlajatang commented Oct 12, 2019

Destragon commented Oct 12, 2019

ghost commented Oct 12, 2019

Destragon commented Oct 13, 2019

ghost commented Oct 13, 2019

ghost commented Oct 17, 2019

Destragon commented Oct 18, 2019

ghost commented Oct 18, 2019

RustyBrute commented Oct 22, 2019

Night-Pryanik commented Oct 24, 2019

ghost commented Oct 24, 2019

mlangsdorf left a comment

paulenka-aleh commented Oct 30, 2019

ghost commented Oct 31, 2019

stale bot commented Nov 30, 2019

pjf commented Mar 25, 2020 •

edited

Loading

ghost commented Apr 3, 2020

CEG86 commented Apr 25, 2020

ZhilkinSerg commented Apr 25, 2020

Towing vehicles #34690

Towing vehicles #34690

Conversation

ghost commented Oct 12, 2019 • edited by ghost Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

chaisawlajatang commented Oct 12, 2019

Destragon commented Oct 12, 2019

ghost commented Oct 12, 2019

Destragon commented Oct 13, 2019

ghost commented Oct 13, 2019

ghost commented Oct 17, 2019

Destragon commented Oct 18, 2019

ghost commented Oct 18, 2019

RustyBrute commented Oct 22, 2019

Night-Pryanik commented Oct 24, 2019

ghost commented Oct 24, 2019

mlangsdorf left a comment

Choose a reason for hiding this comment

paulenka-aleh commented Oct 30, 2019

ghost commented Oct 31, 2019

stale bot commented Nov 30, 2019

pjf commented Mar 25, 2020 • edited Loading

ghost commented Apr 3, 2020

CEG86 commented Apr 25, 2020

ZhilkinSerg commented Apr 25, 2020

ghost commented Oct 12, 2019 •

edited by ghost

Loading

pjf commented Mar 25, 2020 •

edited

Loading